]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"
authorTakashi Iwai <tiwai@suse.de>
Sun, 24 May 2015 06:27:52 +0000 (08:27 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sun, 24 May 2015 06:32:37 +0000 (08:32 +0200)
commitce9ff35434ef7b97b9b45b79c79e6ec371f96130
treebc2435a4caa039078559a7ebc0153bcf22fe0eaf
parent579d1fdc83daeae6a87d6b73d8ed3e24043e81cb
Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"

This reverts commit 003376f337f68f34089a3f346b7a4b44e5207414.

Through the regression report, it was revealed that the
tpacpi_led_set() call to thinkpad_acpi helper doesn't only toggle the
mute LED but actually mutes the sound.  This is contradiction to the
expectation, and rather confuses user.

According to Henrique, it's not trivial to judge which TP model
behaves "LED-only" and which model does whatever more intrusive, as
Lenovo's implementations vary model by model.  So, from the safety
reason, we should revert the patch for now.

Reported-by: Martin Steigerwald <martin@lichtvoll.de>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/thinkpad_helper.c