]> git.baikalelectronics.ru Git - kernel.git/commit
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_butt...
authorJosé Expósito <jose.exposito89@gmail.com>
Wed, 5 Jan 2022 17:29:15 +0000 (18:29 +0100)
committerJiri Kosina <jkosina@suse.cz>
Thu, 6 Jan 2022 14:39:43 +0000 (15:39 +0100)
commitce8bd269b80851fed0773da0ba84464f16c5064b
treef4d8ce06bbd7ec779d424920488430efeadb21c1
parent37b68a0d20155f0f6cd0c5d5732357d9b962b72c
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad

The function performs a check on the hdev input parameters, however, it
is used before the check.

Initialize the udev variable after the sanity check to avoid a
possible NULL pointer dereference.

Fixes: 87b51005c3c30 ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443763 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-uclogic-params.c