]> git.baikalelectronics.ru Git - kernel.git/commit
vduse: check that offset is within bounds in get_config()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 8 Dec 2021 15:09:56 +0000 (18:09 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Dec 2021 08:32:36 +0000 (09:32 +0100)
commitce838da827bcc9dfb8dae274b8d8a95343c13395
treee3caf65dea3f06b3aee95d70d97f582892923d9d
parent73bfb54e28fae399dcfc51ed64a5f2e12fd65e60
vduse: check that offset is within bounds in get_config()

commit 9ee266bfda90e5c5df88e315e3879b87a5b4f810 upstream.

This condition checks "len" but it does not check "offset" and that
could result in an out of bounds read if "offset > dev->config_size".
The problem is that since both variables are unsigned the
"dev->config_size - offset" subtraction would result in a very high
unsigned value.

I think these checks might not be necessary because "len" and "offset"
are supposed to already have been validated using the
vhost_vdpa_config_validate() function.  But I do not know the code
perfectly, and I like to be safe.

Fixes: 365194a98d97 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211208150956.GA29160@kili
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vdpa/vdpa_user/vduse_dev.c