]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: timer: fix nsec/sec initialization confusion
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sat, 11 Jan 2020 20:33:25 +0000 (14:33 -0600)
committerTakashi Iwai <tiwai@suse.de>
Sun, 12 Jan 2020 08:08:22 +0000 (09:08 +0100)
commitce6593cebf625e5e5801be00baae38fc1f7d32b6
tree57a464c8b28a6643bf36664874e4f11e05ca74f5
parentf3e298772e653043490dc994c2329b5be5ef22fa
ALSA: timer: fix nsec/sec initialization confusion

GCC reports a warning with W=1:

sound/core/timer.c: In function ‘snd_timer_user_read’:
sound/core/timer.c:2219:19: warning: initialized field overwritten
[-Woverride-init]
 2219 |     .tstamp_sec = tread->tstamp_nsec,
      |                   ^~~~~
sound/core/timer.c:2219:19: note: (near initialization for
‘(anonymous).tstamp_sec’)

Assigning nsec values to sec fields is problematic in general, even
more so when the initial goal was to survive the 2030 timer
armageddon.

Fix by using the proper field in the initialization

Cc: Baolin Wang <baolin.wang@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Fixes: 1b961dd6110e3 ("ALSA: Avoid using timespec for struct snd_timer_tread")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20200111203325.20498-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/timer.c