]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: Fix dev pointer dereference from sk_skb
authorJoe Stringer <joe@wand.net.nz>
Fri, 12 Oct 2018 21:50:53 +0000 (14:50 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Sun, 14 Oct 2018 06:03:08 +0000 (23:03 -0700)
commitce5e79cc3fde6f4ec88eae135612e94b1d1d84d3
treed89350111e7bb1c3073d4e1a67d4a8d55735207a
parentd1aef528887f23f5d8c622ff39d17f749d1bf29d
bpf: Fix dev pointer dereference from sk_skb

Dan Carpenter reports:

The patch 4b8337ef7be8: "bpf: Add helper to retrieve socket in BPF"
from Oct 2, 2018, leads to the following Smatch complaint:

    net/core/filter.c:4893 bpf_sk_lookup()
    error: we previously assumed 'skb->dev' could be null (see line 4885)

Fix this issue by checking skb->dev before using it.

Signed-off-by: Joe Stringer <joe@wand.net.nz>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/filter.c