]> git.baikalelectronics.ru Git - kernel.git/commit
crypto: serpent - mark __serpent_setkey_sbox noinline
authorArnd Bergmann <arnd@arndb.de>
Tue, 18 Jun 2019 11:19:42 +0000 (13:19 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 27 Jun 2019 06:28:01 +0000 (14:28 +0800)
commitce5acd8fd01f27daaf02ff4f13f41af69615663e
tree7aced6bb5402810d105b25f07090ccad78200644
parent6ddc4f64a3b4fbf04f717fba98885cb98979a2a4
crypto: serpent - mark __serpent_setkey_sbox noinline

The same bug that gcc hit in the past is apparently now showing
up with clang, which decides to inline __serpent_setkey_sbox:

crypto/serpent_generic.c:268:5: error: stack frame size of 2112 bytes in function '__serpent_setkey' [-Werror,-Wframe-larger-than=]

Marking it 'noinline' reduces the stack usage from 2112 bytes to
192 and 96 bytes, respectively, and seems to generate more
useful object code.

Fixes: 3f70380fbec4 ("crypto: serpent - improve __serpent_setkey with UBSAN")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/serpent_generic.c