]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove
authorJanusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Fri, 18 Oct 2019 10:07:10 +0000 (12:07 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 18 Oct 2019 21:42:59 +0000 (22:42 +0100)
commitce1b9d1b0c995ac2374f99cd577611a498693173
treefcbe25b772228dab6757aef1016808078369b1bd
parent6d7bafe6565a12181025377eea3b5e22bf46a249
drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

Commit 7ae4ca1a09d8 ("drm/i915: add i915_driver_modeset_remove()")
claimed removal of asymmetry in probe() and remove() calls, however, it
didn't take care of calling intel_irq_uninstall() on driver remove.
That doesn't hurt as long as we still call it from
intel_modeset_driver_remove() but in order to have full symmetry we
should call it again from i915_driver_modeset_remove().

Note that it's safe to call intel_irq_uninstall() twice thanks to
commit 9d2f701816f5 ("drm/i915: Nuke drm_driver irq vfuncs").  We may
only want to mention the case we are adding in a related FIXME comment
provided by that commit.  While being at it, update the name of
function mentioned as calling it out of sequence as that name has been
changed meanwhile by commit 2e50c6fbab58 ("drm/i915: Propagate
"_remove" function name suffix down").

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/6250061.7lZMOAyebC@jkrzyszt-desk.ger.corp.intel.com
drivers/gpu/drm/i915/i915_drv.c
drivers/gpu/drm/i915/i915_irq.c