]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda: Don't release card at firmware loading error
authorTakashi Iwai <tiwai@suse.de>
Mon, 13 Apr 2020 08:20:29 +0000 (10:20 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 13 Apr 2020 16:02:09 +0000 (18:02 +0200)
commitcdbbd3946a4ad7e4ba8cb450800cade787121845
treebf8cfba5ff6960fda149f77d02fa7c2b474e9b05
parentd870ce24d822e1f12ef26c3e3d92b3abe8b3c2df
ALSA: hda: Don't release card at firmware loading error

At the error path of the firmware loading error, the driver tries to
release the card object and set NULL to drvdata.  This may be referred
badly at the possible PM action, as the driver itself is still bound
and the PM callbacks read the card object.

Instead, we continue the probing as if it were no option set.  This is
often a better choice than the forced abort, too.

Fixes: a36aa3a9e5a0 ("ALSA: hda - Deferred probing with request_firmware_nowait()")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207043
Link: https://lore.kernel.org/r/20200413082034.25166-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c