]> git.baikalelectronics.ru Git - kernel.git/commit
net: systemport: fix double shift of a vlan_tci by VLAN_PRIO_SHIFT
authorColin Ian King <colin.king@canonical.com>
Wed, 8 Jul 2020 18:37:23 +0000 (19:37 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Jul 2020 20:06:56 +0000 (13:06 -0700)
commitcd96cb5026816151d833a99d419a95bba7377c01
treec85ef5f027b9c7fa43fdbbf04f28381f5fdbe91a
parent3801c112b59a05834254a6687ded68e21f0f84d1
net: systemport: fix double shift of a vlan_tci by VLAN_PRIO_SHIFT

Currently the u16 skb->vlan_tci is being right  shifted twice by
VLAN_PRIO_SHIFT, once in the macro skb_vlan_tag_get_pri and explicitly
by VLAN_PRIO_SHIFT afterwards. The combined shift amount is larger than
the u16 so the end result is always zero.  Remove the second explicit
shift as this is extraneous.

Fixes: 40ef90f04d0b ("net: systemport: Add support for VLAN transmit acceleration")
Addresses-Coverity: ("Operands don't affect result")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcmsysport.c