]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "USBNET: ax88179_178a: enable tso if usb host supports sg dma"
authorMathias Nyman <mathias.nyman@linux.intel.com>
Fri, 7 Mar 2014 15:06:58 +0000 (17:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2014 19:48:13 +0000 (11:48 -0800)
commitcd7c1a21be826fb5678068a90cd8dbca56e86633
tree4d9aa6bb0be0bae44f2ecc7c65e6e9e56ac6b85e
parent4fe14b9f1bc8676a9d61b2358c146b85531dd7d4
Revert "USBNET: ax88179_178a: enable tso if usb host supports sg dma"

This reverts commit 1d1ef311e7b8fed056d2b88f46fd7a926edf5a9c.

This commit, together with commit 12858b52864e40bc17a982d5a17878fc00e4c6d9
"xhci 1.0: Limit arbitrarily-aligned scatter gather." were
origially added to get xHCI 1.0 hosts and usb ethernet ax88179_178a devices
working together with scatter gather. xHCI 1.0 hosts pose some requirement on how transfer
buffers are aligned, setting this requirement for 1.0 hosts caused USB 3.0 mass
storage devices to fail more frequently.

USB 3.0 mass storage devices used to work before 3.14-rc1.  Theoretically,
the TD fragment rules could have caused an occasional disk glitch.
Now the devices *will* fail, instead of theoretically failing.
>From a user perspective, this looks like a regression; the USB device obviously
fails on 3.14-rc1, and may sometimes silently fail on prior kernels.

The proper soluition is to implement the TD fragment rules for xHCI 1.0 hosts,
but for now, revert this patch until scatter gather can be properly supported.

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/ax88179_178a.c