]> git.baikalelectronics.ru Git - kernel.git/commit
PM / clk: Fix clock error check in __pm_clk_add()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 8 May 2015 08:47:43 +0000 (10:47 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 19 May 2015 13:13:19 +0000 (15:13 +0200)
commitccfbe3bd7beafc0b8592c5625a3efb2e3c65532d
tree7f48755fd8c37ea85da76eb1e7c5403436eea3d4
parentea38b1538ed1fa8b5dc060eca5fd4b86c12985f0
PM / clk: Fix clock error check in __pm_clk_add()

In the final iteration of commit f326e6b90f707aab ("PM / clock_ops: Add
pm_clk_add_clk()"), a refcount increment was added by Grygorii Strashko.
However, the accompanying IS_ERR() check operates on the wrong clock
pointer, which is always zero at this point, i.e. not an error.
This may lead to a NULL pointer dereference later, when __clk_get()
tries to dereference an error pointer.

Check the passed clock pointer instead to fix this.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: f326e6b90f707aab ("PM / clock_ops: Add pm_clk_add_clk()")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/clock_ops.c