]> git.baikalelectronics.ru Git - kernel.git/commit
cifs: destage any unwritten data to the server before calling copychunk_write
authorRonnie Sahlberg <lsahlber@redhat.com>
Thu, 21 Apr 2022 01:15:36 +0000 (11:15 +1000)
committerSteve French <stfrench@microsoft.com>
Thu, 21 Apr 2022 03:54:54 +0000 (22:54 -0500)
commitccd54398e5669061354247c5914f08b32bc3e3d0
tree00c6b71fb425817a6afb3e2e355b22387da2aefd
parentb1b135db869cc3156c50b144d919f434a832bd73
cifs: destage any unwritten data to the server before calling copychunk_write

because the copychunk_write might cover a region of the file that has not yet
been sent to the server and thus fail.

A simple way to reproduce this is:
truncate -s 0 /mnt/testfile; strace -f -o x -ttT xfs_io -i -f -c 'pwrite 0k 128k' -c 'fcollapse 16k 24k' /mnt/testfile

the issue is that the 'pwrite 0k 128k' becomes rearranged on the wire with
the 'fcollapse 16k 24k' due to write-back caching.

fcollapse is implemented in cifs.ko as a SMB2 IOCTL(COPYCHUNK_WRITE) call
and it will fail serverside since the file is still 0b in size serverside
until the writes have been destaged.
To avoid this we must ensure that we destage any unwritten data to the
server before calling COPYCHUNK_WRITE.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1997373
Reported-by: Xiaoli Feng <xifeng@redhat.com>
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2ops.c