]> git.baikalelectronics.ru Git - kernel.git/commit
ACPI / video: Revert "ACPI / video: driver must be registered before checking for...
authorHans de Goede <hdegoede@redhat.com>
Thu, 14 Jan 2016 08:41:45 +0000 (09:41 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 15 Jan 2016 21:09:06 +0000 (22:09 +0100)
commitcbf23f892bf5f4ba8718c3bf43936edc255c8c4d
treec7c6a2df26a86838ecd7251736134d9a84839884
parenteb353f0b1b62f673c430e4d59a8d8c2646e5d6ee
ACPI / video: Revert "ACPI / video: driver must be registered before checking for keypresses"

On systems with an intel video opcode region, the completion used in the
patch this commit reverts will only complete if the i915 driver loads.

If for some reason the i915 driver never loads calls to
acpi_video_handles_brightness_key_presses() may be delayed indefinitely.

This reverts commit 7b421ad5f95e ("ACPI / video: driver must be registered
before checking for keypresses") fixing this.

This reintroduces a potential NULL pointer deref due to using an
uninitalized mutex, this is fixed differently in a follow-up patch.

Fixes: 7b421ad5f95e (ACPI / video: driver must be registered before checking for keypresses)
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpi_video.c