]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: imx6q: cpuidle: fix bug that CPU might not wake up at expected time
authorKohji Okuno <okuno.kohji@jp.panasonic.com>
Tue, 26 Feb 2019 02:34:13 +0000 (11:34 +0900)
committerShawn Guo <shawnguo@kernel.org>
Tue, 19 Mar 2019 08:48:00 +0000 (16:48 +0800)
commitcbee90dcca6bd45d53066b97dd2372ee493b58f2
tree4f4168bd2bbd1187defe7c2f787ba76d8e92acbf
parentbb15543c87882dd5241676914cdce65ca98d7fad
ARM: imx6q: cpuidle: fix bug that CPU might not wake up at expected time

In the current cpuidle implementation for i.MX6q, the CPU that sets
'WAIT_UNCLOCKED' and the CPU that returns to 'WAIT_CLOCKED' are always
the same. While the CPU that sets 'WAIT_UNCLOCKED' is in IDLE state of
"WAIT", if the other CPU wakes up and enters IDLE state of "WFI"
istead of "WAIT", this CPU can not wake up at expired time.
 Because, in the case of "WFI", the CPU must be waked up by the local
timer interrupt. But, while 'WAIT_UNCLOCKED' is set, the local timer
is stopped, when all CPUs execute "wfi" instruction. As a result, the
local timer interrupt is not fired.
 In this situation, this CPU will wake up by IRQ different from local
timer. (e.g. broacast timer)

So, this fix changes CPU to return to 'WAIT_CLOCKED'.

Signed-off-by: Kohji Okuno <okuno.kohji@jp.panasonic.com>
Fixes: c6333bbe0402 ("ARM: imx6q: support WAIT mode using cpuidle")
Cc: <stable@vger.kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/mach-imx/cpuidle-imx6q.c