]> git.baikalelectronics.ru Git - kernel.git/commit
inet: Fix __inet_inherit_port() to correctly increment bsockets and num_owners
authorNagendra Tomar <tomer_iisc@yahoo.com>
Fri, 26 Nov 2010 14:26:27 +0000 (14:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Nov 2010 02:18:44 +0000 (18:18 -0800)
commitcbec04c598120b43a6a0af28979b049b8db8d6f7
treeb64a78c4a7950e6b43c3e882dfc6dbe3a88aa2ea
parent82ec7c0452734cd024cd26e5165213543517068e
inet: Fix __inet_inherit_port() to correctly increment bsockets and num_owners

inet sockets corresponding to passive connections are added to the bind hash
using ___inet_inherit_port(). These sockets are later removed from the bind
hash using __inet_put_port(). These two functions are not exactly symmetrical.
__inet_put_port() decrements hashinfo->bsockets and tb->num_owners, whereas
___inet_inherit_port() does not increment them. This results in both of these
going to -ve values.

This patch fixes this by calling inet_bind_hash() from ___inet_inherit_port(),
which does the right thing.

'bsockets' and 'num_owners' were introduced by commit 4b00edfcd96c2434
(inet: Allowing more than 64k connections and heavily optimize bind(0))

Signed-off-by: Nagendra Singh Tomar <tomer_iisc@yahoo.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_hashtables.c