]> git.baikalelectronics.ru Git - kernel.git/commit
HID: thingm: set the proper error code before leaving
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tue, 2 Sep 2014 19:50:43 +0000 (15:50 -0400)
committerJiri Kosina <jkosina@suse.cz>
Wed, 3 Sep 2014 21:46:09 +0000 (23:46 +0200)
commitca904889ac008a6f7843c7998aa2f2f7859293c4
treec18319e8e323b883689c68711674a1de828ee233
parent86347b1b3d49cd0672488e99b5d733c67560e2ff
HID: thingm: set the proper error code before leaving

In case of an unsupported firmware, the driver bails out without setting
the LEDs interfaces, but forget to set the proper error code.
err is then still equal to 0 and the hid subsytem consider the device
to be in perfect shape.
When removing it, thingm_remove() tries to unbind the rgb LEDs which
has not been created, leading to a segfault.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-thingm.c