]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: cs5535audio: Fix the missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 10:26:08 +0000 (12:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:34:06 +0000 (09:34 +0200)
commitca424481dafb8a25099c6d7898c8837207711fb4
treecf68dc4ac98a5e25b5ced05f19695d5f5f2f02e4
parent12621a4dff85160b7f81447e127d8eb726046050
ALSA: cs5535audio: Fix the missing snd_card_free() call at probe error

commit a4768d74ccfaaf00c0aad31bfd8113f40f72917e upstream.

The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature.  Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().

Fixes: 2150777c9936 ("ALSA: cs5535audio: Allocate resources with device-managed APIs")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220412102636.16000-12-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/cs5535audio/cs5535audio.c