]> git.baikalelectronics.ru Git - kernel.git/commit
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
authorNikos Tsironis <ntsironis@arrikto.com>
Fri, 27 Mar 2020 14:01:11 +0000 (16:01 +0200)
committerMike Snitzer <snitzer@redhat.com>
Fri, 27 Mar 2020 18:42:51 +0000 (14:42 -0400)
commitca30b70cda1b446ab0d7956d456d7dc32af28447
tree76cc780f85a499ce39c5cbbf585812d64625902f
parent98e3f61aadd69a5122353ec652166af58d8bc5a3
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()

dm_clone_nr_of_hydrated_regions() returns the number of regions that
have been hydrated so far. In order to do so it employs bitmap_weight().

Until now, the return type of dm_clone_nr_of_hydrated_regions() was
unsigned long.

Because bitmap_weight() returns an int, in case BITS_PER_LONG == 64 and
the return value of bitmap_weight() is 2^31 (the maximum allowed number
of regions for a device), the result is sign extended from 32 bits to 64
bits and an incorrect value is displayed, in the status output of
dm-clone, as the number of hydrated regions.

Fix this by having dm_clone_nr_of_hydrated_regions() return an unsigned
int.

Fixes: 926c5639707c ("dm: add clone target")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Nikos Tsironis <ntsironis@arrikto.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-clone-metadata.c
drivers/md/dm-clone-metadata.h
drivers/md/dm-clone-target.c