]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "isdn: mISDN: Fix potential NULL pointer dereference of kzalloc"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:13 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:32:21 +0000 (18:32 +0200)
commitc9a41eb2ce00b056b8851606b6fe3975006f6755
treed9c12eb85d354f39baab1b7d5e2cb2247471b68a
parent6cca440c5f498a9077e20cad3d5399bc9883de34
Revert "isdn: mISDN: Fix potential NULL pointer dereference of kzalloc"

This reverts commit 1295c468cdbf49cf9dfd6b95fcbc27fbaafee08d.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

While it looks like the original change is correct, it is not, as none
of the setup actually happens, and the error value is not propagated
upwards.

Cc: Aditya Pakki <pakki001@umn.edu>
Cc: David S. Miller <davem@davemloft.net>
Link: https://lore.kernel.org/r/20210503115736.2104747-47-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/isdn/hardware/mISDN/hfcsusb.c