]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: ipset: Fix overflow before widen in the bitmap_ip_create() function.
authorGavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Wed, 11 Jan 2023 11:57:39 +0000 (11:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:58:21 +0000 (11:58 +0100)
commitc94fa3cda15f73716c3311a64cbcaf2135732592
treea357d886a9dbb468c93b3c060b140c84e0dce314
parent37706873f58303b83a0cf9f333fff4411147818f
netfilter: ipset: Fix overflow before widen in the bitmap_ip_create() function.

commit 8bbb51ff0864c4a54f783ec91c24a3bc2f061e48 upstream.

When first_ip is 0, last_ip is 0xFFFFFFFF, and netmask is 31, the value of
an arithmetic expression 2 << (netmask - mask_bits - 1) is subject
to overflow due to a failure casting operands to a larger data type
before performing the arithmetic.

Note that it's harmless since the value will be checked at the next step.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: c72abb109707 ("netfilter: ipset: Check and reject crazy /0 input parameters")
Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/ipset/ip_set_bitmap_ip.c