]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "printk: wake up all waiters"
authorJohn Ogness <john.ogness@linutronix.de>
Thu, 26 May 2022 20:30:56 +0000 (22:36 +0206)
committerPetr Mladek <pmladek@suse.com>
Fri, 27 May 2022 11:04:46 +0000 (13:04 +0200)
commitc90768f819308651f02a1d92b5997e4eb27a54a8
treed6f705499b2731a75747a9eaf0e541a8c5d70ec6
parenta2f61d6a6a4dac08f8c6c8ffb0d6d37c7b3499fa
Revert "printk: wake up all waiters"

This reverts commit 27786f87d99ee758bb488ebc523a6c53df9bff6b.

The wait queue @log_wait never has exclusive waiters, so there
is no need to use wake_up_interruptible_all(). Using
wake_up_interruptible() was the correct function to wake all
waiters.

Since there are no exclusive waiters, erroneously changing
wake_up_interruptible() to wake_up_interruptible_all() did not
result in any behavior change. However, using
wake_up_interruptible_all() on a wait queue without exclusive
waiters is fundamentally wrong.

Go back to using wake_up_interruptible() to wake all waiters.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220526203056.81123-1-john.ogness@linutronix.de
kernel/printk/printk.c