]> git.baikalelectronics.ru Git - kernel.git/commit
i40e: fix condition of WARN_ONCE for stat strings
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 20 Aug 2018 15:12:27 +0000 (08:12 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 24 Aug 2018 15:52:35 +0000 (08:52 -0700)
commitc8e9aa41f7f49a37bea542946eab9449059d5473
tree9f46ad230e558251b9dbcbddfedae289dc7ed318
parente066359ff39eae3f91455cf78b3c6aeab725983f
i40e: fix condition of WARN_ONCE for stat strings

Commit 26d5b841061c ("i40e: use WARN_ONCE to replace the commented
BUG_ON size check") introduced a warning check to make sure
that the size of the stat strings was always the expected value. This
code accidentally inverted the check of the data pointer. Fix this so
that we accurately count the size of the stats we copied in.

This fixes an erroneous WARN kernel splat that occurs when requesting
ethtool statistics.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Tested-by: Mauro S M Rodrigues <maurosr@linux.vnet.ibm.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_ethtool.c