]> git.baikalelectronics.ru Git - kernel.git/commit
wimax/i2400m: remove debug containing bogus calculation of index
authorColin Ian King <colin.king@canonical.com>
Fri, 30 Aug 2019 09:07:11 +0000 (10:07 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Aug 2019 19:31:52 +0000 (12:31 -0700)
commitc8c32c183e74a4cc9bc76f98bab88510ed5907d0
tree5e6330edaf836bc70225cc14a8aaa6ca8c509611
parent89397a6e519d50d040845275e5a2cd00f9d7c5eb
wimax/i2400m: remove debug containing bogus calculation of index

The subtraction of the two pointers is automatically scaled by the
size of the size of the object the pointers point to, so the division
by sizeof(*i2400m->barker) is incorrect.  This has been broken since
day one of the driver and is only debug, so remove the debug completely.

Also move && in condition to clean up a checkpatch warning.

Addresses-Coverity: ("Extra sizeof expression")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wimax/i2400m/fw.c