]> git.baikalelectronics.ru Git - kernel.git/commit
media: ov2659: make S_FMT succeed even if requested format doesn't match
authorAkinobu Mita <akinobu.mita@gmail.com>
Sat, 30 Mar 2019 14:01:31 +0000 (10:01 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 22 Apr 2019 15:34:50 +0000 (11:34 -0400)
commitc8a51fc594fad7b25e80ca0a41aa3c8c30b0e1a3
tree4c6d52fe477f7a00a888ffe9fb9ce6e5c5e8f0aa
parente12c95af30ce03bc95746ad6371b093d201c0556
media: ov2659: make S_FMT succeed even if requested format doesn't match

This driver returns an error if unsupported media bus pixel code is
requested by VIDIOC_SUBDEV_S_FMT.

But according to Documentation/media/uapi/v4l/vidioc-subdev-g-fmt.rst,

Drivers must not return an error solely because the requested format
doesn't match the device capabilities. They must instead modify the
format to match what the hardware can provide.

So select default format code and return success in that case.

This is detected by v4l2-compliance.

Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/ov2659.c