]> git.baikalelectronics.ru Git - kernel.git/commit
net: sfp: fix memory leak in sfp_probe()
authorJianglei Nie <niejianglei2021@163.com>
Wed, 29 Jun 2022 07:55:50 +0000 (15:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 18:59:25 +0000 (20:59 +0200)
commitc884f7d7cb70dc613e526e6f91a2d0732f0f02ad
treee791e5d527ae95b0ed04895a759aa599006bec45
parent028802e51a41e0c775560568fe4f63de9a753b05
net: sfp: fix memory leak in sfp_probe()

[ Upstream commit 1257e3f81cd8cb05a0cc25beb4f4a28379c9003b ]

sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When
devm_add_action() fails, sfp is not freed, which leads to a memory leak.

We should use devm_add_action_or_reset() instead of devm_add_action().

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/20220629075550.2152003-1-niejianglei2021@163.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/sfp.c