]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: pnv_php: Add missing of_node_put()
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 23 May 2018 19:07:15 +0000 (21:07 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 23 May 2018 21:48:37 +0000 (16:48 -0500)
commitc8589d24862346b070302b274a8a0b029f6ce186
tree4ce20fe54f68c122a6188425ec7abf7f6c823201
parentb589ea3d6cb600b2c208cf3f49412b3c6fe46639
PCI: pnv_php: Add missing of_node_put()

The device node iterators perform an of_node_get() on each iteration, so a
jump out of the loop requires an of_node_put().

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/pnv_php.c