]> git.baikalelectronics.ru Git - kernel.git/commit
xen-blkback: fix error handling in xen_blkbk_map()
authorJan Beulich <jbeulich@suse.com>
Mon, 15 Feb 2021 07:56:44 +0000 (08:56 +0100)
committerJuergen Gross <jgross@suse.com>
Mon, 15 Feb 2021 07:56:44 +0000 (08:56 +0100)
commitc8251c1c58c0bc7ebba550036e69d49d805dfc79
tree31bdf5ee41af83e487cd234fa7b947e5c9165a8b
parent2bcebfed8ea9854ef94d92fcd448d4846cfde43e
xen-blkback: fix error handling in xen_blkbk_map()

The function uses a goto-based loop, which may lead to an earlier error
getting discarded by a later iteration. Exit this ad-hoc loop when an
error was encountered.

The out-of-memory error path additionally fails to fill a structure
field looked at by xen_blkbk_unmap_prepare() before inspecting the
handle which does get properly set (to BLKBACK_INVALID_HANDLE).

Since the earlier exiting from the ad-hoc loop requires the same field
filling (invalidation) as that on the out-of-memory path, fold both
paths. While doing so, drop the pr_alert(), as extra log messages aren't
going to help the situation (the kernel will log oom conditions already
anyway).

This is XSA-365.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Julien Grall <julien@xen.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/block/xen-blkback/blkback.c