]> git.baikalelectronics.ru Git - kernel.git/commit
net: hinic: fix null pointer dereference on pointer hwdev
authorColin Ian King <colin.king@canonical.com>
Thu, 22 Nov 2018 10:05:01 +0000 (10:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 24 Nov 2018 01:22:02 +0000 (17:22 -0800)
commitc720c3710459f11a00ccc8d9f873105732bf8820
tree506b7ee61c3e681b8633d3c386ac55f873d4007f
parentc4b5e1a35dfebfe6606917b7187829ad2deed569
net: hinic: fix null pointer dereference on pointer hwdev

Pointer hwdev is being dereferenced when declaring hwif , however, later
on hwdev is being null checked, hence we have dereference before null
check error. Fix this by assigning hwif and pdef only once hwdev has
been null checked.

Detected by CoverityScan, CID#1485581 ("Dereference before null check")

Fixes: b18c4e4e13a6 ("net-next/hinic:add rx checksum offload for HiNIC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/huawei/hinic/hinic_port.c