]> git.baikalelectronics.ru Git - kernel.git/commit
tcp: do not report TCP_CM_INQ of 0 for closed connections
authorSoheil Hassas Yeganeh <soheil@google.com>
Wed, 6 Mar 2019 18:01:36 +0000 (13:01 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 Mar 2019 19:00:50 +0000 (11:00 -0800)
commitc711a0507d72f90aeafe4797a28e5fd4fc425b30
treeb7becb9ea1b8fd50abbca27ddd36c0b379485b0a
parentc22fb6e22b1bfdb7eb749508b1f6c8af22c79c12
tcp: do not report TCP_CM_INQ of 0 for closed connections

Returning 0 as inq to userspace indicates there is no more data to
read, and the application needs to wait for EPOLLIN. For a connection
that has received FIN from the remote peer, however, the application
must continue reading until getting EOF (return value of 0
from tcp_recvmsg) or an error, if edge-triggered epoll (EPOLLET) is
being used. Otherwise, the application will never receive a new
EPOLLIN, since there is no epoll edge after the FIN.

Return 1 when there is no data left on the queue but the
connection has received FIN, so that the applications continue
reading.

Fixes: 8bef561cb4324 (tcp: send in-queue bytes in cmsg upon read)
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c