]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: check return code from nla_parse_tested
authorDaniel Borkmann <dborkman@redhat.com>
Wed, 12 Jun 2013 15:54:51 +0000 (17:54 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 20 Jun 2013 09:20:13 +0000 (11:20 +0200)
commitc7080b7a85a2372491840eb4ef7b859ad3eec82e
tree79f5f278a8c98d2c569772bb5f7d72836da795d3
parent8445f3de623789cb29cc5f64cfffcdf0f5345ab5
netfilter: check return code from nla_parse_tested

These are the only calls under net/ that do not check nla_parse_nested()
for its error code, but simply continue execution. If parsing of netlink
attributes fails, we should return with an error instead of continuing.
In nearly all of these calls we have a policy attached, that is being
type verified during nla_parse_nested(), which we would miss checking
for otherwise.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_netlink.c
net/netfilter/nfnetlink_cthelper.c
net/netfilter/nfnetlink_cttimeout.c