]> git.baikalelectronics.ru Git - kernel.git/commit
cgroup: Add missing cpus_read_lock() to cgroup_attach_task_all()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Thu, 25 Aug 2022 08:38:38 +0000 (17:38 +0900)
committerTejun Heo <tj@kernel.org>
Thu, 25 Aug 2022 17:36:30 +0000 (07:36 -1000)
commitc6c2a7b790ac609b9a833c011a8dccba5fdbe61f
tree06f2784c54257714e1576003999fae747af04df7
parent6e1c6825b80d0553882b1eeffb65d7ae26498b28
cgroup: Add missing cpus_read_lock() to cgroup_attach_task_all()

syzbot is hitting percpu_rwsem_assert_held(&cpu_hotplug_lock) warning at
cpuset_attach() [1], for commit baf59de3daebd355 ("cgroup: Fix
threadgroup_rwsem <-> cpus_read_lock() deadlock") missed that
cpuset_attach() is also called from cgroup_attach_task_all().
Add cpus_read_lock() like what cgroup_procs_write_start() does.

Link: https://syzkaller.appspot.com/bug?extid=29d3a3b4d86c8136ad9e
Reported-by: syzbot <syzbot+29d3a3b4d86c8136ad9e@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: baf59de3daebd355 ("cgroup: Fix threadgroup_rwsem <-> cpus_read_lock() deadlock")
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cgroup-v1.c