]> git.baikalelectronics.ru Git - kernel.git/commit
stmmac: Revert "stmmac: align RX buffers"
authorMarc Zyngier <maz@kernel.org>
Fri, 20 Aug 2021 18:30:02 +0000 (19:30 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 Aug 2021 21:44:49 +0000 (14:44 -0700)
commitc6b886481b37d81229af31084179b80f03e9ba31
treeaf1940bcd15713c88b0f2709c9683b90a2bc9bfb
parent8ea50ee53e4f869d996af018c90e818aefbba601
stmmac: Revert "stmmac: align RX buffers"

This reverts commit 0dabe26f1ba7 ("stmmac: align RX buffers"),
which breaks at least one platform (Nvidia Jetson-X1), causing
packet corruption. This is 100% reproducible, and reverting
the patch results in a working system again.

Given that it is "only" a performance optimisation, let's
return to a known working configuration until we can have a
good understanding of what is happening here.

Fixes: 0dabe26f1ba7 ("stmmac: align RX buffers")
Cc: Matteo Croce <mcroce@linux.microsoft.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Link: https://lore.kernel.org/netdev/871r71azjw.wl-maz@kernel.org
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210820183002.457226-1-maz@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac.h