]> git.baikalelectronics.ru Git - kernel.git/commit
capabilities: fix undefined behavior in bit shift for CAP_TO_MASK
authorGaosheng Cui <cuigaosheng1@huawei.com>
Mon, 31 Oct 2022 11:25:36 +0000 (19:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Nov 2022 16:42:05 +0000 (17:42 +0100)
commitc68beea0c746f981d11543d18d0c4132f8808ed1
tree2c9d7ae45fc36c9a3fde582e5f5d444a5c929bb4
parent4614b32fbe07125fc592ba5bd8d9c7f5ecc99689
capabilities: fix undefined behavior in bit shift for CAP_TO_MASK

[ Upstream commit e8e4b6683d8817ee76bb536ece1d47875f5ac282 ]

Shifting signed 32-bit value by 31 bits is undefined, so changing
significant bit to unsigned. The UBSAN warning calltrace like below:

UBSAN: shift-out-of-bounds in security/commoncap.c:1252:2
left shift of 1 by 31 places cannot be represented in type 'int'
Call Trace:
 <TASK>
 dump_stack_lvl+0x7d/0xa5
 dump_stack+0x15/0x1b
 ubsan_epilogue+0xe/0x4e
 __ubsan_handle_shift_out_of_bounds+0x1e7/0x20c
 cap_task_prctl+0x561/0x6f0
 security_task_prctl+0x5a/0xb0
 __x64_sys_prctl+0x61/0x8f0
 do_syscall_64+0x58/0x80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
 </TASK>

Fixes: 59bf6ceeb8d1 ("Add 64-bit capability support to the kernel")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Acked-by: Andrew G. Morgan <morgan@kernel.org>
Reviewed-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/uapi/linux/capability.h