]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: iwl-dbg: Use del_timer_sync() before freeing
authorGuenter Roeck <linux@roeck-us.net>
Mon, 11 Apr 2022 15:42:10 +0000 (08:42 -0700)
committerKalle Valo <kvalo@kernel.org>
Sat, 23 Apr 2022 06:32:12 +0000 (09:32 +0300)
commitc646fcb3d57928b22e45e744702ba7618f432108
treebe7c13e9dad8d1e98e15981b30c9ed76490f1bb5
parent4fd788ed359cff594930d60cf211d2974697470d
iwlwifi: iwl-dbg: Use del_timer_sync() before freeing

In Chrome OS, a large number of crashes is observed due to corrupted timer
lists. Steven Rostedt pointed out that this usually happens when a timer
is freed while still active, and that the problem is often triggered
by code calling del_timer() instead of del_timer_sync() just before
freeing.

Steven also identified the iwlwifi driver as one of the possible culprits
since it does exactly that.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Gregory Greenman <gregory.greenman@intel.com>
Fixes: 14679f2f18668 ("iwlwifi: dbg_ini: add periodic trigger new API support")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Gregory Greenman <gregory.greenman@intel.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # Linux v5.17.3-rc1 and Debian LLVM-14
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220411154210.1870008-1-linux@roeck-us.net
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c