]> git.baikalelectronics.ru Git - kernel.git/commit
llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c)
authorChan Shu Tak, Alex <alexchan@task.com.hk>
Thu, 19 Dec 2019 06:16:18 +0000 (14:16 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Dec 2019 05:19:36 +0000 (21:19 -0800)
commitc5f384577053bfceac2471d06a1e07a4905870c5
tree813b496e56a412f0dfaf103b279709da5f149eef
parent70e9c4400a152d995dca8d4344c6d5a419286f3a
llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c)

When a frame with NULL DSAP is received, llc_station_rcv is called.
In turn, llc_stat_ev_rx_null_dsap_xid_c is called to check if it is a NULL
XID frame. The return statement of llc_stat_ev_rx_null_dsap_xid_c returns 1
when the incoming frame is not a NULL XID frame and 0 otherwise. Hence, a
NULL XID response is returned unexpectedly, e.g. when the incoming frame is
a NULL TEST command.

To fix the error, simply remove the conditional operator.

A similar error in llc_stat_ev_rx_null_dsap_test_c is also fixed.

Signed-off-by: Chan Shu Tak, Alex <alexchan@task.com.hk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/llc/llc_station.c