]> git.baikalelectronics.ru Git - kernel.git/commit
serial: clps711x: Fix bad usage of IS_ERR_VALUE
authorGuenter Roeck <linux@roeck-us.net>
Tue, 9 Feb 2016 15:06:47 +0000 (07:06 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Feb 2016 01:39:36 +0000 (17:39 -0800)
commitc57714e25311521ef40d4297ac5076241f4a76c1
treea7d4617707b57cde5c6f211b3209ec2694f3afe2
parentff89306304d517558bd729c426a38310e46271cd
serial: clps711x: Fix bad usage of IS_ERR_VALUE

IS_ERR_VALUE() assumes that its parameter is an unsigned long.
It can not be used to check if an unsigned int reflects an error.
Doing so can result in the following build warning.

drivers/tty/serial/clps711x.c: In function ‘uart_clps711x_probe’:
include/linux/err.h:21:38: warning:
comparison is always false due to limited range of data type
drivers/tty/serial/clps711x.c:471:6: note: in expansion of macro ‘IS_ERR_VALUE’

If that warning is seen, an error return from platform_get_irq() is missed.

Use a temporary variable to check for errors from platform_get_irq().
Also don't use IS_ERR_VALUE() to check if an integer variable is < 0.
The variable can be checked directly in that case.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/clps711x.c