]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: sdhci-esdhc-imx: correct CQHCI exit halt state check
authorSebastian Falbesoner <sebastian.falbesoner@gmail.com>
Mon, 21 Nov 2022 10:57:21 +0000 (11:57 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2022 10:23:04 +0000 (11:23 +0100)
commitc4ebd013229fbbdf6beaaf96c4309b92e90f2b3a
tree3b21faddacdcc5671f31bc1ddf4e4c20b6044d69
parent4c47303835275bb5541da4d44e44b0b85b5b02ec
mmc: sdhci-esdhc-imx: correct CQHCI exit halt state check

commit da6149bb53576f0ab32fc25f62b5bec1ea60f771 upstream.

With the current logic the "failed to exit halt state" error would be
shown even if any other bit than CQHCI_HALT was set in the CQHCI_CTL
register, since the right hand side is always true. Fix this by using
the correct operator (bit-wise instead of logical AND) to only check for
the halt bit flag, which was obviously intended here.

Fixes: 75b8e6007eb1 ("mmc: sdhci-esdhc-imx: clear the HALT bit when enable CQE")
Signed-off-by: Sebastian Falbesoner <sebastian.falbesoner@gmail.com>
Acked-by: Haibo Chen <haibo.chen@nxp.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221121105721.1903878-1-sebastian.falbesoner@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/sdhci-esdhc-imx.c