]> git.baikalelectronics.ru Git - kernel.git/commit
HID: lenovo: Map mic-mute button to KEY_F20 instead of KEY_MICMUTE
authorHans de Goede <hdegoede@redhat.com>
Sun, 4 Apr 2021 08:04:29 +0000 (10:04 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 7 Apr 2021 10:48:19 +0000 (12:48 +0200)
commitc48cfcbd9a098306555f052ff7027907e5c76a57
treeaaf1a25c194486a29965b6389a094088ca827a43
parent3ed738d8391fc7437037b7d0fa09e9f8f66e7862
HID: lenovo: Map mic-mute button to KEY_F20 instead of KEY_MICMUTE

Mapping the mic-mute button to KEY_MICMUTE is technically correct but
KEY_MICMUTE translates to a scancode of 256 (248 + 8) under X,
which does not fit in 8 bits, so it does not work.

Because of this userspace is expecting KEY_F20 instead,
theoretically KEY_MICMUTE should work under Wayland but even
there it does not work, because the desktop-environment is
listening only for KEY_F20 and not for KEY_MICMUTE.

Fixes: a2edc692b28b ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard support")
Reviewed-by: Marek BehĂșn <kabel@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-lenovo.c