]> git.baikalelectronics.ru Git - kernel.git/commit
brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()
authorArend van Spriel <arend.vanspriel@broadcom.com>
Fri, 7 Jul 2017 20:09:06 +0000 (21:09 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Jul 2017 15:29:56 +0000 (08:29 -0700)
commitc448a3c537c31acde3257ec4a521a20613d53e70
tree493fbb48e6e8e917f61d6e3dccd42aeb77543233
parentcc17ed174cd1bcf8a91ce94d908620bbefd2481d
brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

The lower level nl80211 code in cfg80211 ensures that "len" is between
25 and NL80211_ATTR_FRAME (2304).  We subtract DOT11_MGMT_HDR_LEN (24) from
"len" so thats's max of 2280.  However, the action_frame->data[] buffer is
only BRCMF_FIL_ACTION_FRAME_SIZE (1800) bytes long so this memcpy() can
overflow.

memcpy(action_frame->data, &buf[DOT11_MGMT_HDR_LEN],
       le16_to_cpu(action_frame->len));

Cc: stable@vger.kernel.org # 3.9.x
Fixes: b8213d673a7f7 ("brcmfmac: P2P action frame tx.")
Reported-by: "freenerguo(郭大兴)" <freenerguo@tencent.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c