]> git.baikalelectronics.ru Git - kernel.git/commit
sh_eth: Fix power down vs. is_opened flag ordering
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 18 Jan 2021 15:08:12 +0000 (16:08 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 Jan 2021 00:47:19 +0000 (16:47 -0800)
commitc41dbb359393a1f9dc5df54134bbbd1dea687f7e
treef233ddc1f5e4d35dd32b69df96c008aeee5bb177
parent21ae791914088c38d792be7ff321114a98d91f59
sh_eth: Fix power down vs. is_opened flag ordering

sh_eth_close() does a synchronous power down of the device before
marking it closed.  Revert the order, to make sure the device is never
marked opened while suspended.

While at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as
there is no reason to do a synchronous power down.

Fixes: 67b31f67d2d97bcc ("sh_eth: Fix sleeping function called from invalid context")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20210118150812.796791-1-geert+renesas@glider.be
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/renesas/sh_eth.c