]> git.baikalelectronics.ru Git - kernel.git/commit
net: cls_bpf: fix auto generation of per list handles
authorDaniel Borkmann <dborkman@redhat.com>
Thu, 22 Jan 2015 09:41:02 +0000 (10:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Jan 2015 23:50:19 +0000 (15:50 -0800)
commitc3e4b37c45a5306aff3b506c524b220bf618f75e
tree8d640016c0d8f2edd82147c2c24694f0f0ea3bd0
parent4acf6d41e2e9be6200a4222d46d1308357fea6f8
net: cls_bpf: fix auto generation of per list handles

When creating a bpf classifier in tc with priority collisions and
invoking automatic unique handle assignment, cls_bpf_grab_new_handle()
will return a wrong handle id which in fact is non-unique. Usually
altering of specific filters is being addressed over major id, but
in case of collisions we result in a filter chain, where handle ids
address individual cls_bpf_progs inside the classifier.

Issue is, in cls_bpf_grab_new_handle() we probe for head->hgen handle
in cls_bpf_get() and in case we found a free handle, we're supposed
to use exactly head->hgen. In case of insufficient numbers of handles,
we bail out later as handle id 0 is not allowed.

Fixes: 663bc0c09de9 ("net: sched: cls_bpf: add BPF-based classifier")
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_bpf.c