]> git.baikalelectronics.ru Git - kernel.git/commit
can: sja1000: clear interrupts on start
authorMirza Krak <mirza.krak@hostmobility.com>
Tue, 10 Nov 2015 13:59:34 +0000 (14:59 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 23 Nov 2015 08:35:21 +0000 (09:35 +0100)
commitc3afaf8924bf110fd5970ea3be2e4bf10b63b75a
treefc0323193a1434c3478c1a557382af223f2a34b0
parent6bbfe633f61acc2b4e5226ddb2dec5e915e3d7aa
can: sja1000: clear interrupts on start

According to SJA1000 data sheet error-warning (EI) interrupt is not
cleared by setting the controller in to reset-mode.

Then if we have the following case:
- system is suspended (echo mem > /sys/power/state) and SJA1000 is left
  in operating state
- A bus error condition occurs which activates EI interrupt, system is
  still suspended which means EI interrupt will be not be handled nor
  cleared.

If the above two events occur, on resume there is no way to return the
SJA1000 to operating state, except to cycle power to it.

By simply reading the IR register on start we will clear any previous
conditions that could be present.

Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
Reported-by: Christian Magnusson <Christian.Magnusson@semcon.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/sja1000/sja1000.c