]> git.baikalelectronics.ru Git - kernel.git/commit
igc: igc_read_phy_reg_gpy: drop premature return
authorCorinna Vinschen <vinschen@redhat.com>
Wed, 16 Feb 2022 13:31:35 +0000 (14:31 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 28 Feb 2022 16:48:45 +0000 (08:48 -0800)
commitc366977d5b2101605bb6a02e4169619ef3c863ee
treef0f98ef03657787ffd11d28d1dad07929a194bf8
parent64a75ef0171f05ff0b325b8ba7d399452d6aa5f7
igc: igc_read_phy_reg_gpy: drop premature return

igc_read_phy_reg_gpy checks the return value from igc_read_phy_reg_mdic
and if it's not 0, returns immediately. By doing this, it leaves the HW
semaphore in the acquired state.

Drop this premature return statement, the function returns after
releasing the semaphore immediately anyway.

Fixes: 050f5607e41d ("igc: Add code for PHY support")
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_phy.c