]> git.baikalelectronics.ru Git - kernel.git/commit
mm: filemap: clear idle flag for writes
authorYang Shi <yang.shi@linux.alibaba.com>
Fri, 7 Aug 2020 06:19:55 +0000 (23:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 7 Aug 2020 18:33:23 +0000 (11:33 -0700)
commitc339bccc62faf376e18b660a677694ad613460e1
tree4a2b19eb90d42f76fcabdfc6e44106ba0607d9ea
parent985929bfdd702bc43fb2cdd0666493a72307797e
mm: filemap: clear idle flag for writes

Since commit df6b4f0096fcbb ("mm: filemap: only do access activations on
reads"), mark_page_accessed() is called for reads only.  But the idle flag
is cleared by mark_page_accessed() so the idle flag won't get cleared if
the page is write accessed only.

Basically idle page tracking is used to estimate workingset size of
workload, noticeable size of workingset might be missed if the idle flag
is not maintained correctly.

It seems good enough to just clear idle flag for write operations.

Fixes: df6b4f0096fc ("mm: filemap: only do access activations on reads")
Reported-by: Gang Deng <gavin.dg@linux.alibaba.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@surriel.com>
Link: http://lkml.kernel.org/r/1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/filemap.c