]> git.baikalelectronics.ru Git - kernel.git/commit
mfd: max77693: Do not enforce (incorrect) interrupt trigger type
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 2 Jun 2021 11:04:44 +0000 (13:04 +0200)
committerLee Jones <lee.jones@linaro.org>
Fri, 5 Nov 2021 14:40:06 +0000 (14:40 +0000)
commitc333ef383fe5604d1c8fe92ac41053f7523f412a
tree5ca365bb93519e59ddc0a1fbaf8ad0f7cf4a2214
parentbb0c480466dfafaf91d1e551943f35be083ac141
mfd: max77693: Do not enforce (incorrect) interrupt trigger type

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 77693 datasheet describes the interrupt line as active low
with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and RTC driver, so using level
sensitive interrupt is here especially important to avoid races.  With
an edge configuration in case if first PMIC signals interrupt followed
shortly after by the RTC, the interrupt might not be yet cleared/acked
thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210602110445.33536-3-krzysztof.kozlowski@canonical.com
Documentation/devicetree/bindings/mfd/max77693.txt
drivers/mfd/max77693.c