]> git.baikalelectronics.ru Git - kernel.git/commit
ucc_geth: fix ucc halt problem in half duplex mode
authorYang Li <leoli@freescale.com>
Thu, 25 Nov 2010 23:29:58 +0000 (23:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Nov 2010 02:36:57 +0000 (18:36 -0800)
commitc32273f9089404b40d16686ff1b763cd5c674ea1
treeddb6dd429e12651e1416f477ca10d7d8dc0c77fc
parentcbec04c598120b43a6a0af28979b049b8db8d6f7
ucc_geth: fix ucc halt problem in half duplex mode

In commit 0b6beb99(ucc_geth: Fix the wrong the Rx/Tx FIFO size),
the UCC_GETH_UTFTT_INIT is set to 512 based on the recommendation
of the QE Reference Manual.  But that will sometimes cause tx halt
while working in half duplex mode.

According to errata draft QE_GENERAL-A003(High Tx Virtual FIFO
threshold size can cause UCC to halt), setting UTFTT less than
[(UTFS x (M - 8)/M) - 128] will prevent this from happening
(M is the minimum buffer size).

The patch changes UTFTT back to 256.

Signed-off-by: Li Yang <leoli@freescale.com>
Cc: Jean-Denis Boyer <jdboyer@media5corp.com>
Cc: Andreas Schmitz <Andreas.Schmitz@riedel.net>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ucc_geth.h