]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: target/iblock: Fix overrun in WRITE SAME emulation
authorRoman Bolshakov <r.bolshakov@yadro.com>
Tue, 2 Jul 2019 19:16:38 +0000 (22:16 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 2 Jul 2019 20:35:52 +0000 (16:35 -0400)
commitc30bfe14243bb519d6edd039b9f9a263e7fdd39b
tree3a70919db974650dc2538ea93252758af082e385
parent1313487e74063d740bd13113f6f75c195010668b
scsi: target/iblock: Fix overrun in WRITE SAME emulation

WRITE SAME corrupts data on the block device behind iblock if the command
is emulated. The emulation code issues (M - 1) * N times more bios than
requested, where M is the number of 512 blocks per real block size and N is
the NUMBER OF LOGICAL BLOCKS specified in WRITE SAME command. So, for a
device with 4k blocks, 7 * N more LBAs gets written after the requested
range.

The issue happens because the number of 512 byte sectors to be written is
decreased one by one while the real bios are typically from 1 to 8 512 byte
sectors per bio.

Fixes: fb5d17acd631 ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Cc: <stable@vger.kernel.org>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_iblock.c