]> git.baikalelectronics.ru Git - kernel.git/commit
[media] ddbridge: Do not free_irq() if request_irq() failed
authorTakeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
Wed, 27 May 2015 14:28:14 +0000 (11:28 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 9 Jun 2015 22:40:33 +0000 (19:40 -0300)
commitc2c00e0fb7b65a5aba470064f67786c87a3cc186
tree4ce35fd6ea668fa65b52ddbb9d1f0e75958e501d
parentf468994bf80adf5a80978a7428e484b8c92be4ca
[media] ddbridge: Do not free_irq() if request_irq() failed

My static checker detected that free_irq() is called even after
request_irq() failed in ddb_probe(). In this case, the kernel may try to
free dev->pdev->irq although the IRQ is not assigned. This event rarely
occurs, but always introduces a warning if it happens.

"goto fail1" always results in disabling enabled MSI and releasing a
requested IRQ. It seems like the former handling is necessary. So I added
a conditional branch before the free_irq() (stat == 0 means request_irq()
succeeds).

Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/ddbridge/ddbridge-core.c