]> git.baikalelectronics.ru Git - kernel.git/commit
net: ipa: fix v3.1 resource limit masks
authorCaleb Connolly <caleb.connolly@linaro.org>
Mon, 24 Oct 2022 21:03:32 +0000 (22:03 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 26 Oct 2022 02:48:58 +0000 (19:48 -0700)
commitc255238e8b51f018d1699ae6d138c86fab955132
tree905543b03d7663d384153db4bff685b26a1f181b
parent2d4e794a298c24af6cf9c53781ffb401542964c9
net: ipa: fix v3.1 resource limit masks

The resource group limits for IPA v3.1 mistakenly used 6 bit wide mask
values, when the hardware actually uses 8. Out of range values were
silently ignored before, so the IPA worked as expected. However the
new generalised register definitions introduce stricter checking here,
they now cause some splats and result in the value 0 being written
instead. Fix the limit bitmask widths so that the correct values can be
written.

Fixes: aca5da3e83e5 ("net: ipa: define resource group/type IPA register fields")
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Tested-by: Jami Kettunen <jami.kettunen@somainline.org>
Link: https://lore.kernel.org/r/20221024210336.4014983-2-caleb.connolly@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/reg/ipa_reg-v3.1.c