]> git.baikalelectronics.ru Git - kernel.git/commit
m68k: atari: Make Atari ROM port I/O write macros return void
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 20 May 2022 14:32:30 +0000 (16:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:39 +0000 (10:22 +0200)
commitc1e0c148fa7822af4e23d52f1d46aaeb9780c563
tree838cb0715af02f26655c668aacde372ac5008799
parent9d0ebb0880318f99a7bfb0eddd410e097d83379a
m68k: atari: Make Atari ROM port I/O write macros return void

[ Upstream commit e190e8ce3792091bc73755c0bddcf9f6eeb0079b ]

The macros implementing Atari ROM port I/O writes do not cast away their
output, unlike similar implementations for other I/O buses.
When they are combined using conditional expressions in the definitions of
outb() and friends, this triggers sparse warnings like:

    drivers/net/appletalk/cops.c:382:17: error: incompatible types in conditional expression (different base types):
    drivers/net/appletalk/cops.c:382:17:    unsigned char
    drivers/net/appletalk/cops.c:382:17:    void

Fix this by adding casts to "void".

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
Link: https://lore.kernel.org/r/c15bedc83d90a14fffcd5b1b6bfb32b8a80282c5.1653057096.git.geert@linux-m68k.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/m68k/include/asm/raw_io.h